Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[CI] Update for using purrr 1.0.0; Use rlang::zap() instead of NULL #587

Merged
merged 1 commit into from
Dec 24, 2022
Merged

[CI] Update for using purrr 1.0.0; Use rlang::zap() instead of NULL #587

merged 1 commit into from
Dec 24, 2022

Conversation

eitsupi
Copy link
Member

@eitsupi eitsupi commented Dec 24, 2022

Fix for #585, #586

The following purrr change generates incorrectly formatted docker-bake.json files.

Removing elements with NULL in list_modify() and list_merge() is now fully deprecated.

https://purrr.tidyverse.org/news/index.html

After looking into this change, it seems that rlang::zap() should be used instead of NULL for purrr 1.0.0. (tidyverse/purrr#810)

@eitsupi eitsupi added the CI label Dec 24, 2022
@eitsupi eitsupi changed the title [CI] Update for purrr 1.0.0; Use rlang::zap() instead of NULL [CI] Update for using purrr 1.0.0; Use rlang::zap() instead of NULL Dec 24, 2022
@eitsupi eitsupi merged commit 348e1f3 into rocker-org:master Dec 24, 2022
@eitsupi eitsupi deleted the update-for-purrr-v1 branch December 24, 2022 10:48
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
CI
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
1 participant
@eitsupi